think
16px
820px

PENDIRIAN_PT route flip + legacy retirement — report

Status: COMPLETE. All gates green, zero regressions.

Commits (branch refactor/tidyup-foundation, worktree ahu-ocr-tidyup)

  1. a7dca09 — feat(pt-pendirian): flip /review to the V2 ReviewData engine page
  2. 76010bc — refactor(pt-pendirian): retire the legacy hand-built review page
  3. faca0ba — refactor(pt-pendirian): orphan sweep — dead use-review.ts exports, HelpModal, required-sections type
  4. 7b16888 — refactor(pt-pendirian): retire the legacy POST /:id/submit endpoint + its FE hook
  5. 5738551 — chore(tidyup): mark PENDIRIAN_PT complete in the ReviewData strangler ledger

Not pushed (per instructions).

Test summary

  • Backend: tsc --noEmit clean; full suite 2104 pass / 1 skip / 0 fail across 257 files (2105 total) — down exactly 17 tests from the 2122 baseline, all 17 accounted for by deleted/trimmed /submit-specific assertions (2 files deleted whole: submissions-submit-gate.test.ts 11 tests, pp-bo-submit-bypass.test.ts 2 tests; 3 files trimmed: submissions-mutation-guards.test.ts -2, pp-peralihan-pt-routes.test.ts -1, review-data-finalize.test.ts -1). Zero regressions, no flakes observed.
  • Frontend: tsc --noEmit clean; full suite 855 pass across 118 files — matches the 855/118 baseline (one net-zero: +1 new redirect test file, -1 deleted required-sections.test.ts file).

Concerns

  • None blocking. Two design-rationale comments (services/submission-confirmation-gate.ts, routes/pp-peralihan-pt.ts) referenced the now-deleted /submit route and were updated for accuracy as part of this change, beyond the strict deletion scope but low-risk and directly tied to the retirement.
  • Backend sections/:key/approve / unapprove and identity-matches/:id PATCH routes are now orphaned server-side (their only FE callers, the deleted hooks, are gone) but were left untouched per the brief's explicit scope boundary ("DO NOT touch ... any other route") — flagged for a future cleanup pass, not this one.